set up tracing for SQLite execution (sqlite3_trace_v2):#297
Draft
ikusteu wants to merge 1 commit intorhashimoto:masterfrom
Draft
set up tracing for SQLite execution (sqlite3_trace_v2):#297ikusteu wants to merge 1 commit intorhashimoto:masterfrom
ikusteu wants to merge 1 commit intorhashimoto:masterfrom
Conversation
* create 'libtrace.c' shim (for registering of trace callbacks) * add JS-side shims for tracing * TODO: only SQLITE_TRACE_STMT is currently supported: support other trace messages
FWIW, tracing has proven incredibly useful to me in the past. IMO it definitely makes sense. |
|
@sgbeal Hi, does the official SQLite WASM support that API? Thank you |
Of course - debugging without it is too painful. |
Owner
|
Thanks for the PR! I have no inherent objections to adding this to the supported API. I would add it unconditionally, i.e. not restricted by type of build. What I'd like to see before final review and merge:
If you have any questions or disagree with anything, let's discuss it. I might say, "My way or else!" but we're not at that point yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found
sqlite3_trace_v2incredibly useful for debugging an issue I was working on. I've followed the conventions used in rest of thelib*.(js|c)shims andsqlite-api.jsand thought this might be a good candidate to include in the project.Only the
SQLITE_TRACE_STMTis currently handled (only one I needed) and I'm opening this as a draft as some thing should be clarified:I would love to get your thoughts and, if green-lit, impl the support for other trace variants.
Progress:
Checklist
non-exclusive, royalty-free, irrevocable copyright license to reproduce, prepare
derivative works of, publicly display, sublicense, and distribute this
Contribution and such derivative works.
Contribution contains no content requiring a license from any third party.